Comments on: “Search on this Page” using jQuery

By: Waldek Mastykarz

Waldek Mastykarz — Wed, 31 Mar 2010 04:21:36 +0000

@tfforums: great suggestions. Thanks for the feedback.

By: tfforums

tfforums — Wed, 31 Mar 2010 04:18:37 +0000

OH – i forgot
var searchText = escape(this.value);
searchText=searchText.replace(/%20/gi,"\\s");

makes it search over spaces too.

By: tfforums

tfforums — Wed, 31 Mar 2010 04:17:14 +0000

There are 2 main issues with this script.

1 – it searches within the HTML tags them selves, partially fixed with:

var htmls= $(this).html();
var text= $(this).text();
if(text.match(regx))
{
//original replacement code
}

That way it has to match the text and then replaces on the html – muuuch better but still not 100%

2) if the text wrapper matches multiple – the object only stores the original html for the first instance… fixed by:
// — public methods
this.resetOriginalText= function() {
var instance = this;

$(instance.textWrapper).each(function(i){$(this).html(instance.originalText[i]);});
}

and

this.setOriginalText= function() {
var instance=this;
$(".ms-vb,.ms-vb2").each(function(i){

instance.originalText[i]=$(this).html();
});
instance.set=true;
}

By: Waldek Mastykarz

Waldek Mastykarz — Tue, 25 Aug 2009 09:53:58 +0000

@Suraj: the header you've mentioned is okay with me. Please note, that by including the code in your custom solution you are the one responsible for it, meaning providing any fixes, support, etc.
Glad I could help!

By: Suraj Kurapati

Suraj Kurapati — Tue, 25 Aug 2009 06:45:00 +0000

Hello Waldek,

I want to use this library in my open source project, but it isn\'t clear what license your code was released under (I\'m assuming public domain since you included it in a tutorial).

If there isn\'t a particular license attached to the code, will the following file header be sufficient attribution? Thanks.



/*

  \"Search on this Page\" plugin for jQuery by

  Waldek Mastykarz 
  Published online, on 17 November 2008, at

   and

  
  This source code was extracted directly from this demo page:

  

*/

By: Waldek Mastykarz

Waldek Mastykarz — Tue, 13 Jan 2009 20:01:47 +0000

@Christoph: Thank you for the feedback, Christoph. I appreciate it. As for your question: I believe that the problem has to do with the regular expression which runs the search. I think that the regex engine doesn't recognize spaces as valid characters and would rather expect \s (which could be of course replaced on-the-fly but somehow slipped my mind ).

By: Christoph

Christoph — Tue, 13 Jan 2009 14:23:24 +0000

Waldek,

I really love your site – it's an abounding source of know how and tips. I tested the demo of this script on endusersharepoint.com and it would only work when I entered one search term in the box. Any ideas why it would not work once a space is entered? 'Lorem ipsum' should definitely be found…

By: Waldek Mastykarz

Waldek Mastykarz — Wed, 10 Dec 2008 21:56:24 +0000

@James: I have created a JavaScript equivalent of the Google Chrome search highlight. You can use the JavaScript in any browser.

By: James

James — Wed, 10 Dec 2008 20:25:54 +0000

It's an interesting feature, one that I'd love to use but, alas, I am (for once) crippled by mac and can't use chrome at the moment